Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board: stm32f3_seco_d23: update name and refs #67196

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ektor5
Copy link
Contributor

@ektor5 ektor5 commented Jan 4, 2024

Due to board name change (JUNO -> SBC-3.5-PX30), it is necessary to update board names, links and references in files and documentation.

Closes #67169

@ektor5 ektor5 force-pushed the patch-1 branch 2 times, most recently from 88dd2d6 to 414e4cf Compare January 4, 2024 12:10
@ektor5 ektor5 changed the title board: stm32f3_seco_d23: Update documentation board: stm32f3_seco_d23: update name and refs Jan 4, 2024
@kartben
Copy link
Collaborator

kartben commented Jan 9, 2024

Sorry, didn't see this one as this didn't get through the PR Assignee bot. Looks like there's now a merge conflict, that's bad luck!

kartben
kartben previously approved these changes Jan 9, 2024
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this look good apart from the unfortunate conflict

FRASTM
FRASTM previously approved these changes Jan 10, 2024
@fabiobaltieri
Copy link
Member

@ektor5 can you rebase please?

@ektor5 ektor5 dismissed stale reviews from FRASTM and kartben via 85ffd16 January 10, 2024 19:02
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Jan 10, 2024

You need to actually git rebase and then force push again. :-) We don't use merge commits.

Due to board name change (JUNO -> SBC-3.5-PX30), it is necessary to
update board names, links and references in files and documentation.

Signed-off-by: Ettore Chimenti <[email protected]>
@ektor5
Copy link
Contributor Author

ektor5 commented Jan 10, 2024

@fabiobaltieri I know, I know... just testing how intelligent was the GitHub webUI, nice but still not ideal. 😅

@fabiobaltieri fabiobaltieri merged commit 3557bfe into zephyrproject-rtos:main Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boards: doc: Deadlink in SECO JUNO SBC-D23 documentation page ('boards/arm/stm32f3_seco_d23/doc/index')
5 participants