board: m5stack_stamps3: Add support for M5Stack StampS3 #67130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarteng
force-pushed
the
m5stack_stamps3
branch
4 times, most recently
from
d7fb070 to
f3da72b
Compare
Timing parameters for WS2812C variant of digital RGB. Signed-off-by: Martin Kiepfer <[email protected]>
MrMarteng
force-pushed
the
m5stack_stamps3
branch
from
f3da72b to
8415716
Compare
zephyrbot
added
the
area: Devicetree Binding
|
@galak Any feedback from this PR? |
kartben
requested changes
Jan 10, 2024
| ============ | ||
|
|
||
| M5Stack-StampS3 requires a single 5V input power supply. The module internally | ||
| featues a DCDC (MUN3CAD01-SC) to generate the 3.3V needed for the MCU. |
There was a problem hiding this comment.
Suggested change
| featues a DCDC (MUN3CAD01-SC) to generate the 3.3V needed for the MCU. | |
| features a DCDC (MUN3CAD01-SC) to generate the 3.3V needed for the MCU. |
There was a problem hiding this comment.
Fixed in 38f0a59
sylvioalves
reviewed
Jan 10, 2024
| config ENTROPY_GENERATOR | ||
| default y | ||
|
|
||
| config HEAP_MEM_POOL_SIZE |
There was a problem hiding this comment.
This config has been updated. Please, change it to config HEAP_MEM_POOL_ADD_SIZE_BOARD
There was a problem hiding this comment.
Fixed in 38f0a59
marekmatej
previously approved these changes
Jan 10, 2024
MrMarteng
force-pushed
the
m5stack_stamps3
branch
from
8415716 to
38f0a59
Compare
MrMarteng
changed the title
kartben
reviewed
Jan 11, 2024
Comment on lines
33
to
46
| +---------------+------------------------------------------------------------------+------------+ | ||
| | Key Component | Description | Status | | ||
| +===============+==================================================================+============+ | ||
| || ESP32-S3FN8 || This MPU-ESP32S3 module provides complete Wi-Fi and Bluetooth || supported | | ||
| || module || functionalities and integrates a 8MB flash. || | | ||
| +---------------+------------------------------------------------------------------+------------+ | ||
| || Status LED || One user LED connected via :dtcompatible:`worldsemi,ws2812-spi` || supported | | ||
| || || interface (``led-strip``). || | | ||
| +---------------+------------------------------------------------------------------+------------+ | ||
| || USB Port || USB interface. Power supply for the board as well as the || supported | | ||
| || || communication interface between a computer and the board. || | | ||
| +---------------+------------------------------------------------------------------+------------+ | ||
| | User button | User button (``sw0``) | supported | | ||
| +---------------+------------------------------------------------------------------+------------+ |
There was a problem hiding this comment.
Hey just noticed this, not a big deal as it renders fine apparently, but what's with the double |s? I don't think they are needed? In fact, the only other instance I could find of such an odd instance I could find in-tree is in M5Stack Core2 doc, so my bad for not spotting this before ;-)
Could you please clean it up? FWIW things look good to me otherwise (I wish I would have the hardware at hand to test further though), so here's my virtual +1 :)
MrMarteng
force-pushed
the
m5stack_stamps3
branch
from
38f0a59 to
e45894a
Compare
…oard Adding support for M5Stack StampS3 development board, featuring an ESP32 MCU Signed-off-by: Martin Kiepfer <[email protected]>
MrMarteng
force-pushed
the
m5stack_stamps3
branch
from
e45894a to
413c77e
Compare
kartben
approved these changes
Jan 11, 2024
marekmatej
approved these changes
Jan 11, 2024
sylvioalves
approved these changes
Jan 11, 2024
|
Thanks, @MrMarteng! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for StampS3 IoT Module from M5Stack.