Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FlexCAN on NXP UCANS32K1SIC #67006

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Support FlexCAN on NXP UCANS32K1SIC #67006

merged 3 commits into from
Jan 8, 2024

Conversation

manuargue
Copy link
Member

@manuargue manuargue commented Dec 26, 2023 •
edited
Loading

Add support for FlexCAN on UCANS32K1SIC board.

west twister -p ucans32k1sic --device-testing --device-serial=/dev/ttyUSB_ucans32k1sic -v \
  -T tests/drivers/can -T tests/net/socket/can -T samples/drivers/can -T samples/net/socket/can
INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v3.5.0-3469-gaf59f9e61d0b
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
...
INFO    - 2/7 ucans32k1sic              tests/net/socket/can/net.socket.can                PASSED (device 9.530s)
INFO    - 3/7 ucans32k1sic              tests/drivers/can/shell/drivers.can.shell          PASSED (device 7.673s)
INFO    - 4/7 ucans32k1sic              samples/drivers/can/counter/sample.drivers.can.counter PASSED (device 5.743s)
INFO    - 5/7 ucans32k1sic              samples/drivers/can/babbling/sample.drivers.can.babbling PASSED (device 5.677s)
INFO    - 6/7 ucans32k1sic              tests/drivers/can/timing/drivers.can.timing        PASSED (device 6.341s)
INFO    - 7/7 ucans32k1sic              tests/drivers/can/api/drivers.can.api              PASSED (device 8.061s)

INFO    - 7 test scenarios (7 test instances) selected, 1 configurations skipped (1 by static filter, 0 at runtime).
INFO    - 6 of 7 test configurations passed (100.00%), 0 failed, 0 errored, 1 skipped with 0 warnings in 61.33 seconds
INFO    - In total 100 test cases were executed, 44 skipped on 1 out of total 660 platforms (0.15%)
INFO    - 6 test configurations executed on platforms, 0 test configurations were only built.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 26, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@4605f67 zephyrproject-rtos/hal_nxp@12970d6 zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Dec 26, 2023
@henrikbrixandersen henrikbrixandersen self-assigned this Dec 26, 2023
@mmahadevan108
Copy link
Collaborator

Please update west.yml

henrikbrixandersen
henrikbrixandersen previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once west.yaml is updated with the correct SHA.

bperseghetti
bperseghetti previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@bperseghetti bperseghetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in!

@manuargue
dts: arm: nxp: add FlexCAN support for S32K1xx
c026a49 
S32K1xx devices have a maximum of 3 FlexCAN peripherals. Each part may
define a different maximum number of instances and message buffers,
hence the interrupt lines are defined in the part specific dts.

Signed-off-by: Manuel Argüelles <[email protected]>
@manuargue
drivers: can: flexcan: add support for S32K1xx
21616b0 
Add message buffer allowed values for S32K1xx devices. Except S32K14xW
parts which supports 64 MBs, the rest of the parts support a maximum of
32 MBs.

Signed-off-by: Manuel Argüelles <[email protected]>
@manuargue
boards: arm: ucans32k1sic: enable FlexCAN
57ea377 
Enable FlexCAN peripheral driver for ucans32k1sic board. The GPIO-based
CAN transceiver driver is used to control the on-board CAN transceivers.

Signed-off-by: Manuel Argüelles <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jan 6, 2024
@dleach02 dleach02 merged commit c68564b into zephyrproject-rtos:main Jan 8, 2024
22 of 23 checks passed
@dleach02 dleach02 deleted the manuargue-s32k1-can branch January 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bperseghetti bperseghetti bperseghetti approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@Dat-NguyenDuy Dat-NguyenDuy Awaiting requested review from Dat-NguyenDuy

@dbaluta dbaluta Awaiting requested review from dbaluta

@decsny decsny Awaiting requested review from decsny

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@yvanderv yvanderv Awaiting requested review from yvanderv

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

Assignees

@henrikbrixandersen henrikbrixandersen

@dleach02 dleach02

Labels
area: CAN manifest manifest-hal_nxp platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@manuargue @zephyrbot @mmahadevan108 @henrikbrixandersen @bperseghetti @danieldegrasse @dleach02