Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v2.7-branch] net: ipv4: Check localhost for incoming packet #66887

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Dec 22, 2023

Manual backport of #66645 to 2.7 branch.

Fixes #66888

@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Dec 22, 2023
@jukkar jukkar added the DNM This PR should not be merged (Do Not Merge) label Dec 22, 2023
@jukkar
Copy link
Member Author

jukkar commented Dec 22, 2023

Doing more testing, so added DNM

@jukkar jukkar removed the DNM This PR should not be merged (Do Not Merge) label Dec 22, 2023
@jukkar jukkar requested review from cfriedt and removed request for pfalcon December 22, 2023 13:32
@jukkar jukkar force-pushed the fix/backport/66645-to-v2.7-branch branch from 72ef2fd to ed07025 Compare December 22, 2023 13:42
@jukkar jukkar added the DNM This PR should not be merged (Do Not Merge) label Dec 22, 2023
@jukkar
Copy link
Member Author

jukkar commented Dec 22, 2023

This seems to require more work as there has been many changes in relevant files.

If we receive a packet from non localhost interface, then
drop it if either source or destination address is a localhost
address.

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit 6d41e68)
If we receive a packet where the source address is our own
address, then we should drop it.

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit 19392a6)
@jukkar jukkar force-pushed the fix/backport/66645-to-v2.7-branch branch 2 times, most recently from 259a58b to 496e8e8 Compare December 22, 2023 13:52
@jukkar jukkar removed the DNM This PR should not be merged (Do Not Merge) label Dec 22, 2023
@jukkar jukkar force-pushed the fix/backport/66645-to-v2.7-branch branch from 496e8e8 to 6a666a6 Compare December 27, 2023 09:29
@jukkar jukkar added the Backport Backport PR and backport failure issues label Dec 28, 2023
@cfriedt
Copy link
Member

cfriedt commented Jan 3, 2024

Sorry for the delay - thanks for the backport!

@cfriedt cfriedt merged commit 32748c6 into zephyrproject-rtos:v2.7-branch Jan 3, 2024
24 checks passed
@jukkar jukkar deleted the fix/backport/66645-to-v2.7-branch branch January 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking area: Tests Issues related to a particular existing or missing test Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants