Bluetooth: MICP: Allow for multiple mic_ctrl cb registers #66717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
Thalley
force-pushed
the
micp_multi_cb
branch
from
fcd9b7f to
2b764bc
Compare
Modify the MICP microphone controller callbacks to support multiple registers by making it into a linked list. This allow for multiple applications to get the information from procedures or notifications. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
micp_multi_cb
branch
from
2b764bc to
e7fa7ab
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra and
sjanc
kruithofa
approved these changes
Jan 15, 2024
|
Should we have a test using this? |
We will have that - The CAP tests will register test multiple registers :) |
larsgk
reviewed
Jan 31, 2024
| } | ||
| SYS_SLIST_FOR_EACH_CONTAINER(&micp_mic_ctlr_cbs, tmp, _node) { | ||
| if (tmp == cb) { | ||
| LOG_DBG("Already registered"); |
There was a problem hiding this comment.
Was looking for this one, nice :)
larsgk
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the MICP microphone controller callbacks to support
multiple registers by making it into a linked list.
This allow for multiple applications to get the information
from procedures or notifications.