Bluetooth: VCP/MICP: Fix VOCS and AICS instance counts #66715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
micp_vcp_inst_fix
branch
from
ee3beb3 to
caa434c
Compare
Thalley
force-pushed
the
micp_vcp_inst_fix
branch
from
caa434c to
9805f5c
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra and
sjanc
Thalley
removed request for
larsgk,
jhedberg,
MariuszSkamra,
sjanc,
fredrikdanebjer,
asbjornsabo,
kruithofa and
Casper-Bonde-Bose
The VCP and MICP instances should use their respective AICS and VOCS Kconfig options, rather than the overall Kconfig options. Signed-off-by: Emil Gydesen <[email protected]>
Some places MICP accessed AICS when it was not supported. Signed-off-by: Emil Gydesen <[email protected]>
Some places VCP accessed AICS and VOCS when it was not supported. Also modify existing guards to be consistent with new guards. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
micp_vcp_inst_fix
branch
from
9805f5c to
9993ea2
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra and
sjanc
kruithofa
approved these changes
Feb 2, 2024
fredrikdanebjer
approved these changes
Feb 2, 2024
cvinayak
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VCP and MICP instances should use their respective AICS and VOCS Kconfig options, rather than the overall Kconfig options.