Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: adc: support for Nuvoton numaker ADC #66642

Merged
merged 2 commits into from
Jan 2, 2024
Merged

drivers: adc: support for Nuvoton numaker ADC #66642

merged 2 commits into from
Jan 2, 2024

Conversation

cyliangtw
Copy link
Contributor

This PR is to add Nuvoton numaker series ADC controller.
It's verified on board: NuMaker-PFM-M467.

Depends on zephyrproject-rtos/hal_nuvoton#8

@zephyrbot zephyrbot added platform: Nuvoton Nuvoton area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding platform: Nuvoton NPCX Nuvoton NPCX platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker labels Dec 19, 2023
@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 19, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nuvoton zephyrproject-rtos/hal_nuvoton@584190e zephyrproject-rtos/hal_nuvoton@68a91bb (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nuvoton DNM This PR should not be merged (Do Not Merge) labels Dec 19, 2023
fabiobaltieri
fabiobaltieri reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nitpicks, good stuff

west.yml Outdated Show resolved Hide resolved
drivers/adc/adc_numaker.c Outdated Show resolved Hide resolved
tests/drivers/adc/adc_api/boards/numaker_pfm_m467.overlay Show resolved Hide resolved
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 19, 2023
fabiobaltieri
fabiobaltieri previously approved these changes Dec 19, 2023
View reviewed changes
@cyliangtw
drivers: adc: support Nuvoton numaker series
09afcd1 
Add Nuvoton numaker series adc controller, including async read feature.

Signed-off-by: cyliang tw <[email protected]>
@cyliangtw
tests: drivers: adc: adc_api: support numaker_pfm_m467
885eb1b 
Add support for Nuvoton numaker board numaker_pfm_m467.

Signed-off-by: cyliang tw <[email protected]>
ccli8
ccli8 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ccli8 ccli8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyliangtw
Copy link
Contributor Author

Hi @ssekar15,
If you are available, please look into this PR.

ssekar15
ssekar15 approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@ssekar15 ssekar15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me, thanks.

@carlescufi carlescufi merged commit d001258 into zephyrproject-rtos:main Jan 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssekar15 ssekar15 ssekar15 approved these changes

@ccli8 ccli8 ccli8 approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@MulinChao MulinChao Awaiting requested review from MulinChao

@ChiHuaL ChiHuaL Awaiting requested review from ChiHuaL

@anangl anangl Awaiting requested review from anangl

@galak galak Awaiting requested review from galak

@jackrosenthal jackrosenthal Awaiting requested review from jackrosenthal

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

@sjg20 sjg20 Awaiting requested review from sjg20

Assignees

@anangl anangl

Labels
area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding manifest manifest-hal_nuvoton platform: Nuvoton NPCX Nuvoton NPCX platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker platform: Nuvoton Nuvoton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyliangtw @zephyrbot @fabiobaltieri @ccli8 @ssekar15 @carlescufi @anangl