[Backport v3.5-branch] build: scripts: gen_isr_table: fix bug in level 3 bitmask shifting and minor enhancements #66634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of `THIRD_LVL_INTERRUPTS` bitmask in the `update_masks()` function is wrong, the number of bits to shift should be the sum of the first two levels. Signed-off-by: Yong Cong Sin <[email protected]> (cherry picked from commit 56570cc)
Rename the bitmask variables from `*_LVL_INTERRUPTS` to `INTERRUPT_LVL_BITMASK[]` array to be consistent with `INTERRUPT_BITS`, making it easier to loop over the bitmasks. Signed-off-by: Yong Cong Sin <[email protected]> (cherry picked from commit b4db285)
Add some debug prints for the interrupts bits and bitmasks in each level. Signed-off-by: Yong Cong Sin <[email protected]> (cherry picked from commit 0884a33)
zephyrbot
added
Backport
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
tejlmand
approved these changes
Dec 19, 2023
ycsin
approved these changes
Dec 20, 2023
fabiobaltieri
approved these changes
Dec 20, 2023
jhedberg
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0884a33~3..0884a33 from #66203.
Fixes #66204