[v2.7] toolchain: Move extra warning options to toolchain abstraction #66501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move extra warning option from generic twister script into compiler-dependent config files. ARCMWDT compiler doesn't support extra warning options ex. "-Wl,--fatal-warnings". To avoid build fails flag "disable_warnings_as_errors" should be passed to twister. This allows all warning messages and make atomatic test useles. Signed-off-by: Nikolay Agishev <[email protected]> (cherry picked from commit 0dec4cf)
GCC_VERSION is defined in a few modules, and those headers are often included first, so replace the one used in zephyr with TOOLCHAIN_GCC_VERSION. Do the same with CLANG_VERSION, replacing it with TOOLCHAIN_CLANG_VERSION. BUILD_ASSERT is also defined in include/toolchain/common.h, which might get included before gcc.h. We want to use the gcc-specific one instead of the general one. Signed-off-by: Keith Packard <[email protected]> (cherry picked from commit c58c76e)
|
Also needed to (partially) cherry-pick 6e4f192 to avoid the |
cfriedt
requested review from
keith-packard,
stephanosio,
ycsin,
jgl-meta and
luchnikov
cfriedt
requested review from
nashif,
dcpleung,
andyross,
tejlmand,
abrodkin and
evgeniy-paltsev
as code owners
ycsin
approved these changes
Dec 14, 2023
keith-packard
approved these changes
Dec 14, 2023
|
@tejlmand - should be ready for you if you can take a look. Also @evgeniy-paltsev - your approval would be appreciated as well. |
stephanosio
reviewed
Dec 18, 2023
tejlmand
approved these changes
Dec 19, 2023
@stephanosio - someone at Meta complained directly to myself and @ycsin that this was missing, so I filed the issue and did the backport personally. To that person, it definitely seemed to be a bug in the build system that there was no common way to promote warnings to errors. I could refer that person to you if you would like to argue about it, but you would probably be there a while. Cc @jgl-meta @luchnikov 😂 |
cfriedt
merged commit ce4c30f
into
zephyrproject-rtos:v2.7-branch
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #53305
Fixes #66500
Note: Compliance failure is a false positive (those lines are not modified with this commit)
Move extra warning option from generic twister script into compiler-dependent config files. ARCMWDT compiler doesn't support extra warning options ex. "-Wl,--fatal-warnings". To avoid build fails flag "disable_warnings_as_errors" should be passed to twister.
This allows all warning messages and make atomatic test useles.