Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MCUX_PIT with multiple pit channels #66336

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Enable MCUX_PIT with multiple pit channels #66336

merged 5 commits into from
Mar 7, 2024

Conversation

EmilioCBen
Copy link
Contributor

Enable MCUX_PIT with multiple pit channels

decsny
decsny reviewed Dec 8, 2023
View reviewed changes
soc/arm/nxp_imx/rt/soc_rt11xx.c Outdated Show resolved Hide resolved
drivers/counter/counter_mcux_pit.c Outdated Show resolved Hide resolved
manuargue
manuargue requested changes Dec 9, 2023
View reviewed changes
Copy link
Member

@manuargue manuargue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking support for S32Z2 boards, see https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/arm/nxp/nxp_s32z27x_rtu0_r52.dtsi#L92. Please do the updates needed for these boards and their test overlays.

dts/bindings/counter/nxp,mcux-pit.yaml Outdated Show resolved Hide resolved
drivers/counter/counter_mcux_pit.c Outdated Show resolved Hide resolved
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Jan 15, 2024
@zephyrbot zephyrbot added platform: NXP S32 NXP Semiconductors, S32 platform: NXP Drivers NXP Semiconductors, drivers labels Jan 25, 2024
decsny
decsny reviewed Jan 25, 2024
View reviewed changes
drivers/counter/counter_nxp_pit.c Show resolved Hide resolved
drivers/counter/counter_nxp_pit.c Show resolved Hide resolved
drivers/counter/counter_nxp_pit.c Show resolved Hide resolved
drivers/counter/counter_nxp_pit.c Outdated
}, \
.base = (PIT_Type *)DT_INST_REG_ADDR(n), \
.irq_config_func = nxp_pit_irq_config_func_##n, \
.num_channels = DT_INST_FOREACH_CHILD(n, NXP_PIT_INC_FOR_CHANNEL_COUNT) 0, \
Copy link
Member

@decsny decsny Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant use sep macro?

please investigate sep macro, I think the issue of the 1+ has been solved many times before without defining a 1+ macro

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not valid, the SEP macro requires the use of the node name which will concatenated with the equation node_name_1 + node_name_2, unless I missed some valuable documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DT_INST_FOREACH_CHILD_SEP_VARGS(n, DT_NODE_HAS_COMPAT, (+), nxp_pit_channel)

manuargue
manuargue requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@manuargue manuargue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright legends need updates

doc/releases/migration-guide-3.6.rst Outdated Show resolved Hide resolved
boards/arm/mimxrt1010_evk/mimxrt1010_evk.dts Outdated Show resolved Hide resolved
boards/arm/mimxrt1060_evk/mimxrt1060_evk.dts Outdated Show resolved Hide resolved
boards/arm/mimxrt1160_evk/mimxrt1160_evk_cm7.dts Outdated Show resolved Hide resolved
boards/arm/mimxrt1170_evk/mimxrt1170_evk_cm7.dts Outdated Show resolved Hide resolved
dts/bindings/counter/nxp,pit.yaml Outdated Show resolved Hide resolved
include/zephyr/dt-bindings/clock/imx_ccm.h Outdated Show resolved Hide resolved
include/zephyr/dt-bindings/clock/imx_ccm_rev2.h Outdated Show resolved Hide resolved
soc/arm/nxp_imx/rt/soc_rt11xx.c Outdated Show resolved Hide resolved
tests/drivers/counter/counter_basic_api/boards/mimxrt1060_evk.overlay Outdated Show resolved Hide resolved
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 26, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@c5a5636 zephyrproject-rtos/hal_nxp@ef50604 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dleach02
dleach02 previously approved these changes Feb 6, 2024
View reviewed changes
henrikbrixandersen
henrikbrixandersen previously requested changes Feb 24, 2024
View reviewed changes
doc/releases/migration-guide-3.6.rst Outdated Show resolved Hide resolved
@EmilioCBen EmilioCBen dismissed stale reviews from dleach02 and decsny via c3021e1 February 28, 2024 14:02
@dleach02 dleach02 added the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Mar 1, 2024
nordicjm
nordicjm previously requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs converting to hwmv2

@nordicjm nordicjm removed the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Mar 4, 2024
@EmilioCBen
Copy link
Contributor Author

Needs converting to hwmv2

Should be resolved now

@nordicjm nordicjm dismissed their stale review March 5, 2024 07:19

Addressed

@decsny
Copy link
Member

decsny commented Mar 5, 2024

@henrikbrixandersen please revisit

@henrikbrixandersen henrikbrixandersen dismissed their stale review March 5, 2024 15:49

Release note issue resolved.

@decsny
Copy link
Member

decsny commented Mar 5, 2024

@nordic-krch can you please visit this PR, you're assignee

decsny
decsny previously approved these changes Mar 5, 2024
View reviewed changes
manuargue
manuargue previously approved these changes Mar 6, 2024
View reviewed changes
nordic-krch
nordic-krch previously approved these changes Mar 6, 2024
View reviewed changes
@EmilioCBen
dts: bindings: renamed binding used for pit
737278b 
Renamed pit binding from nxp,kinetis-pit
to nxp,pit

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen
drivers: counter: update nxp_pit api names
f889937 
Update the api named for the new nxp pit
driver.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen
drivers: counter: Adding Mutli Channel PIT Support
19e892a 
Updating the nxp,pit driver to support mutliple
channels. Updating the dts and board overlays
to account for the changes.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen
dts: arm: Enabling pit for imx devices
e9e0777 
Enabled the PIT and Multi channel support
for some of the rtXXXX devices.
- rt1010
- rt1060
- rt1160
- rt1170

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen
boards: arm: Updated the board docs for pit
77eb425 
Updated the board documentation to reflect
the enablement of the PIT peripheral.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen EmilioCBen dismissed stale reviews from nordic-krch, manuargue, and decsny via 77eb425 March 6, 2024 15:32
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Mar 6, 2024
@dleach02 dleach02 requested a review from nordic-krch March 7, 2024 17:58
@dleach02
Copy link
Member

dleach02 commented Mar 7, 2024

Merging as @nordic-krch +1 was removed when we updated the manifest to point to the merged HAL side.

@dleach02 dleach02 merged commit 25830e3 into zephyrproject-rtos:main Mar 7, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldegrasse danieldegrasse danieldegrasse left review comments

@decsny decsny decsny approved these changes

@dleach02 dleach02 dleach02 approved these changes

@bperseghetti bperseghetti bperseghetti approved these changes

@nordicjm nordicjm nordicjm left review comments

@mmahadevan108 mmahadevan108 mmahadevan108 left review comments

@henrikbrixandersen henrikbrixandersen henrikbrixandersen left review comments

@manuargue manuargue manuargue left review comments

@yvanderv yvanderv Awaiting requested review from yvanderv

@Dat-NguyenDuy Dat-NguyenDuy Awaiting requested review from Dat-NguyenDuy

@dbaluta dbaluta Awaiting requested review from dbaluta

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@galak galak Awaiting requested review from galak

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

Assignees

@nordic-krch nordic-krch

Labels
area: ADC Analog-to-Digital Converter (ADC) area: Clock Control area: Counter area: Devicetree Binding PR modifies or adds a Device Tree binding manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP S32 NXP Semiconductors, S32 platform: NXP NXP Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.