-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts: arm: renesas: ra: fix incorrect node name for sci devices #66179
dts: arm: renesas: ra: fix incorrect node name for sci devices #66179
Conversation
The sci devices described in the device tree source for RA MCUs are incorrectly specified as being UARTs when they should be SCIs (serial communication interfaces) which can not only operate as UARTs but also as I2C, SPI etc. Signed-off-by: Ian Morris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey thanks, I think that status = <disable>
should go as well since there's no driver backing renesas,ra-sci
and the device is enabled by enabling the uart
child node, otherwise you'd get in a weird config where the child is enabled but the parent is not, which is harmless but does not look quite right, what do you think?
Thank you for catching my mistakes. There is a similar implementation in stm32, for example, zephyr/dts/arm/st/f1/stm32f1.dtsi Lines 243 to 258 in 21e3749
There is no driver corresponding to "st,stm32-timers" here. zephyr/boards/arm/stm32f103_mini/stm32f103_mini.dts Lines 105 to 114 in 21e3749
When using timer or pwm, set status="okay" for both parent and child. It is certainly a strange configuration, and originally it would be desirable to check it with DTC, but the impact is too large. |
@soburi fair enough, I'm happy with either. |
The sci devices described in the device tree source for RA MCUs are incorrectly specified as being UARTs when they should be SCIs (serial communication interfaces) which can not only operate as UARTs but also as I2C, SPI etc.