Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: arm: renesas: ra: fix incorrect node name for sci devices #66179

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

iandmorris
Copy link
Contributor

The sci devices described in the device tree source for RA MCUs are incorrectly specified as being UARTs when they should be SCIs (serial communication interfaces) which can not only operate as UARTs but also as I2C, SPI etc.

The sci devices described in the device tree source for RA MCUs are
incorrectly specified as being UARTs when they should be SCIs (serial
communication interfaces) which can not only operate as UARTs but also
as I2C, SPI etc.

Signed-off-by: Ian Morris <[email protected]>
@henrikbrixandersen henrikbrixandersen added platform: Renesas Renesas platform: Renesas RA Renesas Electronics Corporation, RA labels Jan 3, 2024
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks, I think that status = <disable> should go as well since there's no driver backing renesas,ra-sci and the device is enabled by enabling the uart child node, otherwise you'd get in a weird config where the child is enabled but the parent is not, which is harmless but does not look quite right, what do you think?

@soburi
Copy link
Member

soburi commented Jan 4, 2024

@iandmorris

Thank you for catching my mistakes.

@fabiobaltieri

There is a similar implementation in stm32,

for example,

timers1: timers@40012c00 {
compatible = "st,stm32-timers";
reg = <0x40012c00 0x400>;
clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000800>;
resets = <&rctl STM32_RESET(APB2, 11U)>;
interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
interrupt-names = "brk", "up", "trgcom", "cc";
st,prescaler = <0>;
status = "disabled";
pwm {
compatible = "st,stm32-pwm";
status = "disabled";
#pwm-cells = <3>;
};
};

There is no driver corresponding to "st,stm32-timers" here.
yaml is defined as a common node for the timers.

&timers1 {
st,prescaler = <10000>;
status = "okay";
pwm1: pwm {
status = "okay";
pinctrl-0 = <&tim1_ch1_pwm_out_pa8>;
pinctrl-names = "default";
};
};

When using timer or pwm, set status="okay" for both parent and child.

It is certainly a strange configuration, and originally it would be desirable to check it with DTC, but the impact is too large.
In this case, we can consider checking the status of the parent node using the UART driver.
I'll think about it for a moment.

@fabiobaltieri
Copy link
Member

fabiobaltieri commented Jan 4, 2024

@soburi fair enough, I'm happy with either.

@fabiobaltieri fabiobaltieri merged commit 74468eb into zephyrproject-rtos:main Jan 4, 2024
21 checks passed
@iandmorris iandmorris deleted the ra-uart-sci-fix branch January 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Renesas RA Renesas Electronics Corporation, RA platform: Renesas Renesas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants