Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v3.4-branch] cmake: modules: dts: Fix board revision 0 overlay #65727

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Nov 24, 2023

Backport 4688981 from #65562.

Fixes #65548

Fixes an issue whereby a board revision is 0 and the overlay file
exists but would not be included

Signed-off-by: Jamie McCrae <[email protected]>
(cherry picked from commit 4688981)
@zephyrbot zephyrbot added the Backport Backport PR and backport failure issues label Nov 24, 2023
@nordicjm
Copy link
Collaborator

@kartben seems your CI action is broken here?

@kartben
Copy link
Collaborator

kartben commented Nov 24, 2023

@kartben seems your CI action is broken here?

Wow, super weird. For now I think I'll blame Github, and something wrong with Node.js based actions, cause I really can't think of anything else. https://github.com/zephyrproject-rtos/zephyr/actions/workflows/greet_first_time_contributor.yml?query=is%3Afailure
Will keep an eye on it, thanks @nordicjm!

@jgl-meta
Copy link
Collaborator

@tejlmand can you check to see why the tests fail here?

@nordicjm
Copy link
Collaborator

@tejlmand can you check to see why the tests fail here?

No test is failing, this is a bot that posts messages, it can be ignored

@nordicjm
Copy link
Collaborator

@jgl-meta can this be merged?

@jgl-meta jgl-meta merged commit b194315 into v3.4-branch Dec 12, 2023
18 of 19 checks passed
@nashif nashif deleted the backport-65562-to-v3.4-branch branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants