drivers: virtualization: Map ivshmem-v2 sections individually #65095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramsay0
requested review from
nashif,
carlescufi,
galak,
MaureenHelm,
tbursztyka and
jukkar
as code owners
Recent changes to the arm64 MMU code mean that you can no longer map R/O memory as R/W. Mapping R/W memory now causes a cache invalidation instruction (DC IVAC) that requires write permissions or else a fault is generated. Modify ivshmem-v2 to map each R/O and R/W section individually Signed-off-by: Grant Ramsay <[email protected]>
This driver assumed the ivshmem-v2 output sections would be mapped contiguously, which is no longer true. Modify eth_ivshmem to treat each output section independently Signed-off-by: Grant Ramsay <[email protected]>
gramsay0
force-pushed
the
fix_ivshmem_v2
branch
from
8d2021c to
d90e39f
Compare
carlocaione
approved these changes
Nov 13, 2023
|
Hey, just giving this a bump |
jhedberg
approved these changes
Nov 27, 2023
tbursztyka
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the arm64 MMU code (c9b534c) mean that you can no longer map R/O memory as R/W.
Mapping R/W memory now causes a cache invalidation instruction (DC IVAC) that requires write permissions or else a fault is generated. Modify ivshmem-v2 to map each R/O and R/W section individually.
The eth_ivshmem driver assumed the ivshmem-v2 output sections would be mapped contiguously, which is no longer true. Modify eth_ivshmem to treat each output section independently.
Further discussion: #64779 (comment)
If these changes are accepted, could they please be backported to v3.5-branch?
CC: @carlocaione @xakep-amatop
Fixes: #65894