drivers: rtc: rpi_pico: Add support for the Raspberry Pi Pico RTC #64939
Conversation
zephyrbot
added
area: Devicetree Binding
|
Hello @ajf58, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Overall it looks good, I have requested minor changes, and will request you run the RTC test suite if you haven't already to validate the driver :) (and fix the compliance issues naturally)
ajf58
force-pushed
the
pico_rtc
branch
2 times, most recently
from
df58b12 to
2997249
Compare
|
This should be merged only after #62186 has been merged, so that it uses the new clock definitions |
Added the DNM label :) |
ajf58
force-pushed
the
pico_rtc
branch
2 times, most recently
from
039e4b2 to
905e92a
Compare
|
Looks like #62186 has merged, can we keep this going? |
Now that I've finished work for the year, yes. Locally I've rebased onto the |
|
I think this is ready for another round of review feedback. This driver now includes both the time and the alarm API. TestingI've run this with the RTC API test suite, and got these results: the |
|
Nice, the |
I've done this as requested. |
RTC drivers should validate the `struct rtc_time`'s contents against the provided `mask`. Promote this common code to a new rtc_utils file and modify existing drivers to use this functionality. Extend the test coverage to include verifying this behaviour. This is groundwork ahead of adding support for the RP2040's (as used in the Raspberry Pi Pico) RTC and alarm. Signed-off-by: Andrew Featherstone <[email protected]>
|
I did a quick correction and rebase to address a code-style issue. The CI pipeline failures are due to the runners disappearing:
which I don't think is down to me adding a blank line in a source file ;-). How do we proceed? Does this require someone with higher privileges to re-run the pipeline, for example? |
This adds the minimal get_time/set_time support for the rp2040 and enables support by default on the Pico boards. This doesn't support configuring the clock source or alarm interrupts yet. Signed-off-by: Andrew Featherstone <[email protected]>
This adds support for the alarm functionality of the RPi Pico RTC. Signed-off-by: Andrew Featherstone <[email protected]>
|
Can we get this over the line please? |
|
Hi @ajf58! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
The zephyrproject-rtos#64939 introduced a few convenience function like rtc_utils_validate_rtc_time. However the PR did not replace all occurrences which result on a build error. This add the missing header include to remove a building warning and replace the old function by the new one. Fixes zephyrproject-rtos#81454 Signed-off-by: Gerson Fernando Budke <[email protected]>
The #64939 introduced a few convenience function like rtc_utils_validate_rtc_time. However the PR did not replace all occurrences which result on a build error. This add the missing header include to remove a building warning and replace the old function by the new one. Fixes #81454 Signed-off-by: Gerson Fernando Budke <[email protected]>
The zephyrproject-rtos#64939 introduced a few convenience function like rtc_utils_validate_rtc_time. However the PR did not replace all occurrences which result on a build error. This add the missing header include to remove a building warning and replace the old function by the new one. Fixes zephyrproject-rtos#81454 Signed-off-by: Gerson Fernando Budke <[email protected]>
The #64939 introduced a few convenience function like rtc_utils_validate_rtc_time. However the PR did not replace all occurrences which result on a build error. This add the missing header include to remove a building warning and replace the old function by the new one. Fixes #81454 Signed-off-by: Gerson Fernando Budke <[email protected]> (cherry picked from commit d71d4c0)
The #64939 introduced a few convenience function like rtc_utils_validate_rtc_time. However the PR did not replace all occurrences which result on a build error. This add the missing header include to remove a building warning and replace the old function by the new one. Fixes #81454 Signed-off-by: Gerson Fernando Budke <[email protected]> (cherry picked from commit d71d4c0)
This adds the minimal get_time/set_time support for the RP2040 SOC and enables support by default on the Pico boards. This doesn't support configuring the clock source or alarm interrupts yet.