NXP S32 SoC improvements to accommodate new devices #64872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuargue
requested review from
tbursztyka,
jukkar,
alexanderwachter,
henrikbrixandersen,
mmahadevan108,
dleach02,
MaureenHelm and
galak
as code owners
zephyrbot
added
platform: NXP
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
decsny,
DerekSnell,
EmilioCBen,
PetervdPerk-NXP and
yvanderv
bperseghetti
previously approved these changes
Nov 8, 2023
|
build failures should be fixed with #64995 |
manuargue
requested review from
Dat-NguyenDuy
and removed request for
yvanderv
|
rebased & fixed conflicts |
bperseghetti
previously approved these changes
Nov 12, 2023
decsny
previously approved these changes
Nov 13, 2023
|
@manuargue pls rebase |
zephyrbot
added
area: CAN
and removed
DNM
bperseghetti
previously approved these changes
Nov 14, 2023
|
Kindly rebase. |
To accommodate support for S32K1 devices, it is necessary to rename the existing `s32k` directory, which currently houses support for the S32K3 series, to align with the respective series names. This adjustment is necessary given the distinct differences in core architecture, MPU, peripherals, and other key aspects between the two series. Signed-off-by: Manuel Argüelles <[email protected]>
The existing S32K3 Kconfig options employ the `M7` suffix, which is redundant given that all cores in this series utilize an Arm Cortex-M7 core. Therefore, we should remove it. Signed-off-by: Manuel Argüelles <[email protected]>
Currently, the NXP S32 SoCs have three redundant Kconfig hidden options to define the part number. To streamline this, we will retain `CONFIG_SOC_PART_NUMBER` to store the part number as a string and `CONFIG_SOC_PART_NUMBER_<part>` that can be selected by the boards. Furthermore, for drivers requiring conditional code compilation based on the target SoC, they should utilize the series or SoC config option as applicable, instead of the part number config. Signed-off-by: Manuel Argüelles <[email protected]>
dleach02
approved these changes
Nov 15, 2023
bperseghetti
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming directory for S32K1 support:
The
s32kdirectory, which currently supports the S32K3 series, is renamed to align with the respective series names and to accommodate S32K1 devices. This adjustment is necessary due to significant differences in core architecture, MPU, peripherals, and other key aspects between the two series.Streamlining Kconfig options:
The S32K3 Kconfig options currently using the 'M7' suffix are simplified by removing this suffix, as all devices in the S32K3 series feature an Arm Cortex-M7 core. Also in order to remove redundancy, the part number configuration options are consolidated by keeping
CONFIG_SOC_PART_NUMBERto store the part number as a string andCONFIG_SOC_PART_NUMBER_<part>to be selected by the boards.