Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.2] dts: vendor-prefixes: deprecate facebook and add meta #64274

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Oct 23, 2023

Backport of #61351 for v3.2-branch.

Fixes #61337
Fixes #61380

Although there are no in-tree users, we will deprecate the
`facebook` vendor prefix and add `meta`.

Signed-off-by: Christopher Friedt <[email protected]>
(cherry picked from commit 02f4aeb)
@cfriedt cfriedt self-assigned this Oct 23, 2023
@cfriedt cfriedt marked this pull request as ready for review October 23, 2023 17:47
@cfriedt cfriedt requested a review from galak as a code owner October 23, 2023 17:47
@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Oct 23, 2023
@fabiobaltieri
Copy link
Member

hey @cfriedt, 3.2 is unsupported, don't think we should backport that far

@cfriedt
Copy link
Member Author

cfriedt commented Oct 23, 2023

@fabiobaltieri - I think we might have had some teams using that branch internally.. but ... trying very much to upstream / reduce forking internally and this is (maybe surprisingly) the easiest way to at least set a good example to ensure things are consistent.

I'm fine with this is dropped, but @henrikbrixandersen reminded me that I had broken backports to update.

CC @DaWei8823

@fabiobaltieri
Copy link
Member

I see your point but unless it's really an major obstacle for you I'd rather close this and not push anything on unsupported releases. This in particular is not a big deal, but then we'd end up merging on old release branches forever. I think at that point you should really keep your fork if you are based on a way out of date release.

@henrikbrixandersen
Copy link
Member

Not entirely sure why this even needs to be backported (to any branch)? I mean, we usually do not backport deprecations - and we support out-of-tree lists of vendor prefixes.

@cfriedt
Copy link
Member Author

cfriedt commented Oct 24, 2023

Not entirely sure why this even needs to be backported (to any branch)?

Well, it's because facebook legally changed it's name a while ago, we have internal forks of Zephyr, and several teams will need a coherent migration strategy.

I mean, we usually do not backport deprecations

Yea. I'm not actually sure why facebook was added here in the first place without having an in-tree driver of some kind, but it's there, and we should try not to break out of tree users. I think we have a few drivers that could be submitted upstream before LTS.

and we support out-of-tree lists of vendor prefixes.

As I mentioned already, doing it in-tree is (maybe surprisingly) the easiest way for me to ensure that it is consistent.

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should backport these kind of changes. We support out-of-tree vendor prefix files for this.

Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value in the backport to 3.2 as it's not supported, and I don't see Zephyr looking to make a 3.2.x release any time soon. That said, if it makes a supporter of Zephyr's life easier to have unreleased changes in an upstream branch that won't impact anyone else.. I don't see the downside here.

@mbolivar-ampere
Copy link
Contributor

I agree with @dkalowsk

@henrikbrixandersen henrikbrixandersen added the Backport Backport PR and backport failure issues label Nov 7, 2023
@cfriedt cfriedt closed this Nov 8, 2023
@cfriedt cfriedt deleted the v3.2-backport-deprecate-facebook-add-meta branch January 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants