Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v3.5-branch] doc: zbus: fix VDED notification sequence figure #64249

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Backport v3.5-branch] doc: zbus: fix VDED notification sequence figure #64249

merged 1 commit into from
Oct 31, 2023

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Oct 23, 2023 •
edited by rodrigopex
Loading

Backport 32bdb24 from #64200.

Fixes #64328

@rodrigopex @github-actions
doc: zbus: fix VDED notification sequence figure
28894b3 
The figure and table related to the VDED notification sequence were wrong.
It fixes that by changing the image and adjusting the table content.

Signed-off-by: Rodrigo Peixoto <[email protected]>
(cherry picked from commit 32bdb24)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: Zbus labels Oct 23, 2023
@zephyrbot zephyrbot requested a review from rodrigopex October 23, 2023 10:38
@henrikbrixandersen
Copy link
Member

@rodrigopex This needs a bug report in order to be backported.

rodrigopex
rodrigopex reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rodrigopex rodrigopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue (#64328) was created.

@henrikbrixandersen
Copy link
Member

The issue (#64328) was created.

Great! Now it just needs approvals ;)

jhedberg
jhedberg approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Question: does the doc build actually take into account changes made to stable release branches? I.e. will content under https://docs.zephyrproject.org/3.5.0/* be eventually updated based on changes like this?

@jhedberg
Copy link
Member

will content under https://docs.zephyrproject.org/3.5.0/* be eventually updated based on changes like this?

...and I just noticed that the above link also contains the third version component (0), so 3.5.1 would have a different URL.

@jhedberg
Copy link
Member

@rodrigopex your approval is still needed here

@jhedberg jhedberg merged commit ebe1ef0 into v3.5-branch Oct 31, 2023
18 checks passed
@nashif nashif deleted the backport-64200-to-v3.5-branch branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@rodrigopex rodrigopex rodrigopex approved these changes

@nashif nashif Awaiting requested review from nashif nashif is a code owner

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

Assignees

@rodrigopex rodrigopex

Labels
area: Zbus Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zephyrbot @henrikbrixandersen @jhedberg @rodrigopex @fabiobaltieri