Proposal NFC subsystem including nRF-NFCT drivers, nt3h2 driver and sample app. #64142
Conversation
HesselM
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
zephyrbot
added
platform: nRF
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @HesselM, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
|
This is a non starter, a resounding no, none of this code nor the libraries are apache licensed, please read https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-guidelines |
HesselM
force-pushed
the
v3.4-branch-nfc
branch
2 times, most recently
from
d72d6e8 to
82e3548
Compare
|
@thedjnK : fixed the licenses on all files we created. |
|
I think you misunderstood my comment:
|
henrikbrixandersen
added
DNM
There was a problem hiding this comment.
@thedjnK : fixed the licenses on all files we created.
this PR has lots of binaries, this is a no-go, nevermind what the license or who the copyright holder is. Please consult the contribution guidelines. Please close and contribute following our guidelines.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
I haven't got time to patch the requests yet. I guess it should be possible to keep the nrfxlib libraries as-is, including them from their original repo's and only include a vanilla-zephyr NFC driver for it (as is shown in this PR). That way this PR does not include the (nordic) binaries. As for the TNEP headers and files I have to check for possibilities: either drop it and only support raw-access to the NFC memory or retrieve it from the nrf-modules. |
Copy not released (zephyrproject-rtos#64142) NFC driver from https://github.com/Sendrato/zephyr/tree/v3.5-branch-nfc (Apache-2.0), which contains NRF modules (ndef, t2t, t4t, tnep) from https://github.com/nrfconnect/sdk-nrf (LicenseRef-Nordic-5-Clause). Signed-off-by: Alex Tsitsiura <[email protected]>
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
HesselM
requested review from
aescolar,
daor-oti,
andyross and
jhedberg
as code owners
jukkar
removed request for
stephanosio,
ibirnbaum,
rerickson1,
ssekar15,
MulinChao,
ChiHuaL,
Mani-Sadhasivam,
mmahadevan108,
simonguinot,
ifyall,
npal-cy,
greg-leach and
bbolen
HesselM
force-pushed
the
v3.4-branch-nfc
branch
2 times, most recently
from
4ebfae8 to
db488cd
Compare
HesselM
force-pushed
the
v3.4-branch-nfc
branch
5 times, most recently
from
9c323f6 to
b2a173b
Compare
NFC driver structure to support multiple NFC driver with the same API Signed-off-by: Hessel van der Molen <[email protected]>
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Hi all,
During the past 2 year we've worked with different boards whom supported NFC.
To ease our lives we made our own subsystem, provided in this PR.
When I came across #5703 I decided to push our approach to public space.
The proposed setup is upgraded to zephyr-3.4 and includes the latest NFC-drivers from the nrf-sdk and nrfxlib.
It also includes a sample app and supports the nt3h2.