Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: add hpmicro hpm6750evkmini board #64117

Closed
wants to merge 7 commits into from
Closed

boards: add hpmicro hpm6750evkmini board #64117

wants to merge 7 commits into from

Conversation

Cherish-Gww
Copy link
Contributor

This is an risc-v board. we also add hpmicro SoC support, as well as gpio, pinctrl, uart driver.

@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: RISCV RISCV Architecture (32-bit & 64-bit) area: Pinctrl area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO labels Oct 19, 2023
@zephyrbot zephyrbot added manifest manifest-hal_hpmicro DNM This PR should not be merged (Do Not Merge) labels Oct 19, 2023
@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 19, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_hpmicro N/A zephyrproject-rtos/hal_hpmicro#3 zephyrproject-rtos/hal_hpmicro#3/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@Cherish-Gww Cherish-Gww mentioned this pull request Oct 19, 2023
Closed
gmarull
gmarull requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR needs to be split into meaningful commits.

fkokosinski
fkokosinski previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@fkokosinski fkokosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boards/riscv, dts/riscv and soc/riscv LGTM

@Cherish-Gww
Copy link
Contributor Author

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

@Cherish-Gww Cherish-Gww dismissed stale reviews from fkokosinski and gmarull via 0e65de7 December 29, 2023 08:28
@fkokosinski
Copy link
Member

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

Hi! Ideally, you'd need to get ACKs from maintainers of the areas that you're modifying here, e.g. gpio, serial etc. You also can ask for help on the #pr-help channel on Discord.

@Cherish-Gww
Copy link
Contributor Author

boards/riscv, dts/riscv and soc/riscv LGTM

@fkokosinski What should I do next?

Hi! Ideally, you'd need to get ACKs from maintainers of the areas that you're modifying here, e.g. gpio, serial etc. You also can ask for help on the #pr-help channel on Discord.

Oh Thanks you very much, I will continue to modify this PR.

@Cherish-Gww Cherish-Gww force-pushed the add_hpmicro_support branch 6 times, most recently from a05f353 to 86b88ab Compare February 19, 2024 09:16
@Cherish-Gww
soc: riscv: andes_v5: add hpmicro soc support
80f7576 
This is an risc-v core chip with dual-core processor.

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
modules: Add hpmicro HAL module
b2d1c55 
Add the hpmicro HAL module to the west mainfest.

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
drivers: pinctrl: Add hpmicro pinctrl driver
5ef55cf 
This commit adds a pinctrl driver for the hpmicro family of processors

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
drivers: clock_control: Add hpmicro clock control driver
d04c647 
This commit adds a clock control driver for hpmicro family of processors.

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
drivers: gpio: Add hpmicro gpio driver
5c9a217 
This commit adds a gpio driver for hpmicro family of processors.

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
drivers: serial: Add hpmicro uart driver
5fcb575 
This commit adds a uart driver for the hpmicro family of processors.

Signed-off-by: Weiwei Guo <[email protected]>
@Cherish-Gww
boards: add hpmicro hpm6750evkmini board
d177873 
This is an risc-v board with dual-core processor.

Signed-off-by: Weiwei Guo <[email protected]>
nordicjm
nordicjm requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be migrated to hwmv2

@Cherish-Gww
Copy link
Contributor Author

Needs to be migrated to hwmv2

OK, I will understand hwmv2 and modify my PR as soon as possible.

@Cherish-Gww
Copy link
Contributor Author

Needs to be migrated to hwmv2

Should I submit my PR to the collab-hwm branch? and change to hwmv2?

@nordicjm
Copy link
Collaborator

Needs to be migrated to hwmv2

Should I submit my PR to the collab-hwm branch? and change to hwmv2?

Can use what is on hwmv2 as a starting point to see how to transition but we will not be merging new boards/socs into that branch

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 28, 2024
@github-actions github-actions bot closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm requested changes

@gmarull gmarull gmarull left review comments

@fkokosinski fkokosinski fkokosinski left review comments

@nashif nashif Awaiting requested review from nashif

@mnkp mnkp Awaiting requested review from mnkp

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@kgugala kgugala Awaiting requested review from kgugala

@pgielda pgielda Awaiting requested review from pgielda

@carlocaione carlocaione Awaiting requested review from carlocaione

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@katsuster katsuster Awaiting requested review from katsuster

@mgielda mgielda Awaiting requested review from mgielda

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

Assignees

@fkokosinski fkokosinski

Labels
area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO area: Pinctrl area: Process area: RISCV RISCV Architecture (32-bit & 64-bit) area: UART Universal Asynchronous Receiver-Transmitter DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_hpmicro Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cherish-Gww @zephyrbot @fkokosinski @nordicjm @gmarull