Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: drivers: deprecate driver init levels #63384

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

nguyenmthien
Copy link
Contributor

Remove deprecated driver initialization levels in the docs.

Remove deprecated driver initialization levels in the docs.

Signed-off-by: Thien Nguyen <[email protected]>
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those levels are not deprecated.

@nguyenmthien
Copy link
Contributor Author

Those levels are not deprecated.

Those are deprecated in this commit

@nashif
Copy link
Member

nashif commented Oct 2, 2023

Those are deprecated in this commit

initialization of devices in this level is deprecated, not the init level itself.

@nguyenmthien
Copy link
Contributor Author

Those are deprecated in this commit

initialization of devices in this level is deprecated, not the init level itself.

This file is the documentation for the device driver model, and not the init system as a whole right?

@nashif
Copy link
Member

nashif commented Oct 2, 2023

This file is the documentation for the device driver model, and not the init system as a whole right?

afaik this is the only place init levels are documented in the docs.

@nguyenmthien
Copy link
Contributor Author

This file is the documentation for the device driver model, and not the init system as a whole right?

afaik this is the only place init levels are documented in the docs.

The wording of the removed sentences and the page title make it clear that this content is meant for device drivers only. IMO, the lack of documentation for SYS_INIT() does not constitute the necessity of including deprecated APIs in driver inits.

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering this is a page dedicated to drivers, changes make sense. SYS_INIT Doxygen documents init levels in detail https://docs.zephyrproject.org/latest/doxygen/html/group__sys__init.html

@nashif nashif merged commit a0b746e into zephyrproject-rtos:main Nov 14, 2023
@nguyenmthien nguyenmthien deleted the drivers branch November 15, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants