Sensor: driver: TI TMAG5273 3D Hall Sensor

[deveritec-rosc]

Product Homepage:
https://www.ti.com/product/TMAG5273

DataSheet:
https://www.ti.com/lit/ds/symlink/tmag5273.pdf

Tested on a custom hardware with nRF52840.

Signed-off-by: Robert Schulze [email protected]

[deveritec-rosc]

The compliance tests fail with

a326f05b93cbaa4927eddca90036fb263c0e54f7 tests: logging: log_api: Fix test_log_arguments case
Traceback (most recent call last):
  File "./scripts/ci/check_compliance.py", line 20, in <module>
    from yamllint import config, linter
ModuleNotFoundError: No module named 'yamllint'

Could somebody please tell me why this is happening so I have a chance to fix this?

[cfriedt]

The compliance tests fail with

a326f05b93cbaa4927eddca90036fb263c0e54f7 tests: logging: log_api: Fix test_log_arguments case
Traceback (most recent call last):
  File "./scripts/ci/check_compliance.py", line 20, in <module>
    from yamllint import config, linter
ModuleNotFoundError: No module named 'yamllint'

Could somebody please tell me why this is happening so I have a chance to fix this?

@deveritec-rosc - it's possible you may need to rebase, do a west update, and then also re-install dependencies with pip -r scripts/requirements.txt

See the Getting Started Guide for more info.

https://docs.zephyrproject.org/latest/develop/getting_started/index.html

[MaureenHelm]

Thank you for the contribution.

There are a lot of code style issues that need to be addressed. Please review the details in the failed compliance check and fix by amending the original commit rather than adding a fixup commit.

[deveritec-rosc]

Hopefully everything done so far. Kind of tricky coming from a project with different styling rules, hope everything is resolved :)

[cfriedt]

Some minor nits, but also, I think a lot of the Kconfig choices should probably be converted to Device Tree bindings. The main advantage there is that they are compile time const but not global, and can therefore be set on a per-device-instance basis.

Kconfig for configuring software, Device Tree for configuring software.

[MaureenHelm]

Please clean up the code style issues, move instance configuration options to devicetree properties, and see if you can reuse the built-in CRC functions in include/zephyr/sys/crc.h

[deveritec-rosc]

Updated the code so that all hardware specific options are now located in the dts-file.
Will take a look at the CRC and remaining issues after the weekend.

[fabiobaltieri]

I just finished the "pseudo-simultaneous" feature and would love to add it today, would this be okay, or better a new PR?

Your call, if you have it ready, you may as well.

[kartben]

pretty cool stuff :)

[kartben]

@MaureenHelm will you be able to have another look? I am pretty confident that your previous review can safely be dismissed, but of course it would be better if you can do a quick last past :)

[dleach02]

@deveritec-rosc please address the merge conflicts

[kartben]

@fabiobaltieri @henrikbrixandersen @MaureenHelm please help get this in for 3.6. This was approved on Friday but needed a rebase (the classical fun of I2C sensors conflicting with each other in the I2C.dtsi file)