Bluetooth: Host: Set conn->err in prio

The goal is to not access `buf` in the non-prio `hci_disconn_complete` so that the buffer does not need to be retained. This commit moves the copy of `conn->err` to the prio handler. Signed-off-by: Aleksander Wasaznik <[email protected]>
zephyrproject-rtos · Feb 2, 2024 · a3c8fab · a3c8fab
1 parent 0bc1a2b
commit a3c8fab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/subsys/bluetooth/host/hci_core.c b/subsys/bluetooth/host/hci_core.c
@@ -838,6 +838,8 @@ static void hci_disconn_complete_prio(struct net_buf *buf)
 		return;
 	}
 
+	conn->err = evt->reason;
+
 	bt_conn_set_state(conn, BT_CONN_DISCONNECT_COMPLETE);
 	bt_conn_unref(conn);
 }
@@ -860,8 +862,6 @@ static void hci_disconn_complete(struct net_buf *buf)
 		return;
 	}
 
-	conn->err = evt->reason;
-
 	bt_conn_set_state(conn, BT_CONN_DISCONNECTED);
 
 	if (conn->type != BT_CONN_TYPE_LE) {