Skip to content

Commit

Permalink
doc: clarify role of CODEOWNERS and MAINTAINERS files
Browse files Browse the repository at this point in the history
Change docs to use MAINTAINERS file as the main file for managing code
areas and 'ownership'.

Signed-off-by: Anas Nashif <[email protected]>
  • Loading branch information
nashif committed Nov 16, 2023
1 parent feb6742 commit 538abf3
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
7 changes: 6 additions & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@
# add others as needed.

# Do not use wildcard on all source yet
# * @galak @nashif
#
# +++++++++++ NOTE ++++++++++++++++
#
# Please use the MAINTAINERS file to add yourself in an area or to add a new
# component or code. This file is going to be deprecated and currently only had
# entries that are not covered by the MAINTAINERS file.

/soc/arm/aspeed/ @aspeeddylan
/soc/arm/atmel_sam/common/*_sam4l_*.c @nandojve
Expand Down
4 changes: 2 additions & 2 deletions doc/contribute/guidelines.rst
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,8 @@ workflow here:
request for the ``main`` branch. The title and message from your commit
message should appear as well.

#. GitHub will assign one or more suggested reviewers (based on the
CODEOWNERS file in the repo). If you are a project member, you can
#. A bot will assign one or more suggested reviewers (based on the
MAINTAINERS file in the repo). If you are a project member, you can
select additional reviewers now too.

#. Click on the submit button and your pull request is sent and awaits
Expand Down
9 changes: 5 additions & 4 deletions doc/project/dev_env_and_tools.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ and linked to any relevant :ref:`bug or feature tracking issues<bug_reporting>`

The Zephyr project uses GitHub for code reviews and Git tree management. When
submitting a change or an enhancement to any Zephyr component, a developer
should use GitHub. GitHub automatically assigns a responsible reviewer on a
component basis, as defined in the :zephyr_file:`CODEOWNERS` file stored with the code
tree in the Zephyr project repository. A limited set of release managers are
allowed to merge a pull request into the main branch once reviews are complete.
should use GitHub. GitHub Actions automatically assigns a responsible reviewer
on a component basis, as defined in the :zephyr_file:`MAINTAINERS.yml` file
stored with the code tree in the Zephyr project repository. A limited set of
release managers are allowed to merge a pull request into the main branch once
reviews are complete.

.. _review_time:

Expand Down

0 comments on commit 538abf3

Please sign in to comment.