Skip to content

Commit

Permalink
net: l2: wifi: wifi_utils: Resolve build warning with strncpy function
Browse files Browse the repository at this point in the history
GCC generates the following build warning from the strncpy call in
"wifi_utils_parse_scan_bands":

warning: '__builtin_strncpy' output truncated before terminating nul
copying as many bytes from a string as its length

To resolve this warning, pass the maximum length of the temporary
parse_str buffer to strncpy. This also has the benefit of correctly null
terminating parse_str, since we already verify the
scan_bands_str is properly null terminated with the strlen() check in
this function. We can therefore remove the line adding a null terminator
to parse_str as well.

Signed-off-by: Daniel DeGrasse <[email protected]>
  • Loading branch information
danieldegrasse committed Jan 10, 2024
1 parent e5b3231 commit 2900c2d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions subsys/net/l2/wifi/wifi_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ int wifi_utils_parse_scan_bands(char *scan_bands_str, uint8_t *band_map)
return -EINVAL;
}

strncpy(parse_str, scan_bands_str, len);
parse_str[len] = '\0';
strncpy(parse_str, scan_bands_str, sizeof(parse_str));

band_str = strtok_r(parse_str, ",", &ctx);

Expand Down

0 comments on commit 2900c2d

Please sign in to comment.