tests: Extend test_extension_command_duplicate #780
Conversation
| # will print a warning. | ||
| # West should disregard an extension command if its name is already taken, | ||
| # either by a built-in command or another extension command added earlier. | ||
| # A warning should also appear for each such case. |
There was a problem hiding this comment.
Do you mean: move this comment above the function, or make it a docstring?
So far, I just kept it consistent with other comments in this particular file.
There was a problem hiding this comment.
I meant pydoc. It's placed exactly like a pydoc but just missing the syntax.
I didn't see that all other tests are like this, sorry. I can't see a good reason why. I think starting to use the pydoc syntax would look consistent enough while making progress at the same time.
pydocs are automatically extracted by very many tools including python itself.
There was a problem hiding this comment.
I can't see a good reason why.
I tried to write pydoc for APIs and comments for things that weren't API, as a pattern.
There was a problem hiding this comment.
Thanks @mbolivar , now I see https://docs.zephyrproject.org/latest/develop/west/west-apis.html is extracted from the source. Is that automated somewhere or manual?
I tried to write pydoc for APIs and comments for things that weren't API, as a pattern.
Makes sense but the tests/ are located in an entirely different, top-level directory so they should not interfere.
Either way this should really be written down somewhere.
Apologies @57300 for the off-topic discussion, feel free to ignore.
Yes, I was on an older version. To be honest, I noticed the bug while looking for a crude way to override |
This test is meant to cover the handling of duplicate command names, including the warnings to be emitted. Previously, it only tested the case where two extension commands had the same name. The other case is duplicating a built-in command name, which prompts a different warning message, so update the test to include it. Additionally, ensure that each duplicate command in the test comes from a different project, so that each warning message is expected to contain a different project name. This serves to verify the bug fix from commit edd1cee. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
test-extension-command-duplicate
branch
from
497bf3f to
1349b81
Compare
This test is meant to cover the handling of duplicate command names, including the warnings to be emitted. Previously, it only tested the case where two extension commands had the same name. The other case is duplicating a built-in command name, which prompts a different warning message, so update the test to include it.
Additionally, ensure that each duplicate command in the test comes from a different project, so that each warning message is expected to contain a different project name. This serves to verify the bug fix from commit edd1cee.