Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-12 and PHPCS #2420

Merged
merged 90 commits into from
Dec 4, 2023
Merged

PSR-12 and PHPCS #2420

merged 90 commits into from
Dec 4, 2023

Conversation

niden
Copy link
Contributor

@niden niden commented Nov 28, 2023

To be merged after memory management fixes

  • Changed standard to PSR-12
  • Changed files to abide by the new standard
  • Reformatted code for readability
  • Reorganized code to have methods listed alphabetically (as well as properties, constants etc.)

@niden niden requested a review from Jeckerson November 28, 2023 00:06
@niden niden self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #2420 (e76ef08) into development (1838e03) will decrease coverage by 1.03%.
The diff coverage is 7.02%.

❗ Current head e76ef08 differs from pull request most recent head 5b8de90. Consider uploading reports for the commit 5b8de90 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             development   #2420      +/-   ##
================================================
- Coverage           6.26%   5.23%   -1.03%     
+ Complexity          8164    7891     -273     
================================================
  Files                314     300      -14     
  Lines              21930   26802    +4872     
================================================
+ Hits                1373    1402      +29     
- Misses             20557   25400    +4843     

@Jeckerson Jeckerson merged commit fc61db5 into development Dec 4, 2023
2 of 42 checks passed
@Jeckerson Jeckerson deleted the phpcs-changes branch December 4, 2023 23:06
Copy link

sonarcloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 208 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants