Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow str booleans for osquery file carving opts #1100

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Allow str booleans for osquery file carving opts #1100

merged 1 commit into from
Jan 10, 2025

Conversation

np5
Copy link
Member

@np5 np5 commented Jan 10, 2025

No description provided.

headmin
headmin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@np5 np5 merged commit c51c0cb into main Jan 10, 2025
10 checks passed
@np5 np5 deleted the 20250110_osquery_file_carving_opt branch January 10, 2025 07:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12705362322

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 80.949%
Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/contrib/osquery/models.py 6 7 85.71%
Totals Coverage Status
Change from base Build 12691702755: 0.003%
Covered Lines: 38615
Relevant Lines: 47703
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headmin headmin headmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@np5 @coveralls @headmin