Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incident status in machine list #1067

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix incident status in machine list #1067

merged 1 commit into from
Oct 11, 2024

Conversation

np5
Copy link
Member

@np5 np5 commented Oct 11, 2024

Closed machine incidents belonging to open incidents must be ignored.

@np5
Fix incident status in machine list
073b786 
Closed machine incidents belonging to open incidents must be ignored.
headmin
headmin approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11291038277

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 80.823%
Totals Coverage Status
Change from base Build 11287530803: 0.001%
Covered Lines: 38466
Relevant Lines: 47593
💛 - Coveralls

@np5 np5 merged commit 073b786 into main Oct 11, 2024
10 checks passed
@np5 np5 deleted the 20241011_fix_inventory_list_incident_status branch October 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headmin headmin headmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@np5 @coveralls @headmin