-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset TestTransport on ensureKernelShutdown #90
Reset TestTransport on ensureKernelShutdown #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HypeMC
thanks for this PR :)
requires symfony/symfony#58240
why don't we implement ResetInterface
? So we won't need Symfony 7.2 to benefit from this feature.
Would you mind adding a test which confirms that everything is working? We should test this in both a test which uses InteractsWithMessenger
trait, and a test which doesn't, I guess
@nikophil Hi, the reason is your comment about introducing a BC break. With this approach, the existing method's behavior remains unchanged. Also, symfony/symfony#58240 is a bugfix, so it won't require 7.2.
Sure, no problem, but I don't think I can actually cover the original scenario as it depends on the execution order and a specific test being run first:
|
oups yes, you're right 🤭 let's do your way then!
perfect
yeah... we're doing strange things to test behavior between tests in this library 😅 ... basically, not using |
@nikophil Actually, I just noticed the |
1e85bc1
to
ab2123d
Compare
@nikophil Funny thing, the test was kind of already there, it just didn't work when all tests were run cause it requires |
Don't hesitate to ping me once the fix is released in SF, and I'll merge and release this PR It seems there is a bunch of issues and PR that can be closed as well. Thanks! |
@nikophil The fix has been released by Symfony, however, I don't think it's possible to get the tests for 6.3 and 7.0 to pass since those versions are no longer supported. I'm not sure what to do about this, the fix is valid for all supported versions. |
hey @HypeMC I just discovered that some tests are failing, maybe because of a new version of Symfony. I'll fix them asap, before merging your PR |
@HypeMC would you mind to rebase your PR? |
818f91d
to
688b12c
Compare
released in 1.10.0 |
An alternative approach to #82, requires symfony/symfony#58240