-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce hook services #790
Open
nikophil
wants to merge
1
commit into
zenstruck:2.x
Choose a base branch
from
nikophil:hooks
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
use Zenstruck\Foundry\Factory; | ||
use Zenstruck\Foundry\ObjectFactory; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
* | ||
* @phpstan-import-type Parameters from Factory | ||
* @template T of object | ||
* @implements HookEvent<T> | ||
*/ | ||
final class AfterInstantiate implements HookEvent | ||
{ | ||
public function __construct( | ||
/** @var T */ | ||
public readonly object $object, | ||
/** @phpstan-var Parameters */ | ||
public readonly array $parameters, | ||
/** @var ObjectFactory<T> */ | ||
public readonly ObjectFactory $factory, | ||
) { | ||
} | ||
|
||
public function getObjectClass(): string | ||
{ | ||
return $this->object::class; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
use Zenstruck\Foundry\Factory; | ||
use Zenstruck\Foundry\Persistence\PersistentObjectFactory; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
* | ||
* @phpstan-import-type Parameters from Factory | ||
* @template T of object | ||
* @implements HookEvent<T> | ||
*/ | ||
final class AfterPersist implements HookEvent | ||
{ | ||
public function __construct( | ||
/** @var T */ | ||
public readonly object $object, | ||
/** @phpstan-var Parameters */ | ||
public readonly array $parameters, | ||
/** @var PersistentObjectFactory<T> */ | ||
public readonly PersistentObjectFactory $factory, | ||
) { | ||
} | ||
|
||
public function getObjectClass(): string | ||
{ | ||
return $this->object::class; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
*/ | ||
#[\Attribute(\Attribute::TARGET_CLASS)] | ||
final class AsAfterInstantiateFoundryHook | ||
{ | ||
public function __construct( | ||
public ?string $class = null, | ||
) { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
*/ | ||
#[\Attribute(\Attribute::TARGET_CLASS)] | ||
final class AsAfterPersistFoundryHook | ||
{ | ||
public function __construct( | ||
public ?string $class = null, | ||
) { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
*/ | ||
#[\Attribute(\Attribute::TARGET_CLASS)] | ||
final class AsBeforeInstantiateFoundryHook | ||
{ | ||
public function __construct( | ||
public ?string $class = null, | ||
) { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
use Zenstruck\Foundry\Factory; | ||
use Zenstruck\Foundry\ObjectFactory; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
* | ||
* @phpstan-import-type Parameters from Factory | ||
* @template T of object | ||
* @implements HookEvent<T> | ||
*/ | ||
final class BeforeInstantiate implements HookEvent | ||
{ | ||
public function __construct( | ||
/** @phpstan-var Parameters */ | ||
public array $parameters, | ||
/** @var class-string<T> */ | ||
public readonly string $objectClass, | ||
/** @var ObjectFactory<T> */ | ||
public readonly ObjectFactory $factory, | ||
) { | ||
} | ||
|
||
public function getObjectClass(): string | ||
{ | ||
return $this->objectClass; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
* | ||
* @internal | ||
* @template T of object | ||
*/ | ||
interface HookEvent | ||
{ | ||
/** @return class-string<T> */ | ||
public function getObjectClass(): string; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the zenstruck/foundry package. | ||
* | ||
* (c) Kevin Bond <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Zenstruck\Foundry\Hooks; | ||
|
||
use Symfony\Component\DependencyInjection\ServiceLocator; | ||
|
||
/** | ||
* @author Nicolas PHILIPPE <[email protected]> | ||
* | ||
* @internal | ||
*/ | ||
final class HooksRegistry | ||
{ | ||
public function __construct( | ||
/** @var ServiceLocator<list<callable(HookEvent<object>): void>> */ | ||
private ServiceLocator $serviceLocator, | ||
) { | ||
} | ||
|
||
/** | ||
* @param HookEvent<object> $hookEvent | ||
*/ | ||
public function callHooks(HookEvent $hookEvent): void | ||
{ | ||
foreach ($this->resolveHooks($hookEvent) as $hook) { | ||
($hook)($hookEvent); | ||
} | ||
} | ||
|
||
public static function hookClassSpecificIndex(string $hookEventClass, string $objectClass): string | ||
{ | ||
return "{$hookEventClass}-{$objectClass}"; | ||
} | ||
|
||
/** | ||
* @param HookEvent<object> $hookEvent | ||
* @return list<callable(HookEvent<object>): void> | ||
*/ | ||
private function resolveHooks(HookEvent $hookEvent): array | ||
{ | ||
$objectSpecificIndex = self::hookClassSpecificIndex($hookEvent::class, $hookEvent->getObjectClass()); | ||
|
||
return [ | ||
...$this->serviceLocator->has($hookEvent::class) ? $this->serviceLocator->get($hookEvent::class) : [], | ||
...$this->serviceLocator->has($objectSpecificIndex) ? $this->serviceLocator->get($objectSpecificIndex) : [], | ||
]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a first time, I think this is enough.
Maybe in a second time, if someone needs it, we could implement
TARGET_METHOD
andIS_REPEATABLE
, but this will complexify a lot the DI