feat: throw an error if Factories trait is not used in a KernelTestCase #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
feat/force-using-factories-trait-in-tests
branch
7 times, most recently
from
b28e7cb to
05cef62
Compare
nikophil
commented
Dec 21, 2024
|
|
||
| final class KernelTestCaseWithBothTraitsInWrongOrderTest extends KernelTestCase | ||
| { | ||
| use ResetDatabase, Factories; |
There was a problem hiding this comment.
in my different tests, I noticed that sometimes, the order of these traits could have an impact, so I wanted to test with both cases
kbond
approved these changes
Dec 23, 2024
|
@kbond I think I won't throw directly an error, but add a deprecation instead: Foundry kinda works without the trait in few situations... WDYT? |
nikophil
force-pushed
the
feat/force-using-factories-trait-in-tests
branch
6 times, most recently
from
bdd057d to
dcd6ef8
Compare
nikophil
commented
Jan 9, 2025
Comment on lines
+58
to
+64
| trigger_deprecation( | ||
| 'zenstruck/foundry', | ||
| '2.4', | ||
| 'In order to use Foundry, you must use the trait "%s" in your "%s" tests. This will throw an exception in 3.0.', | ||
| KernelTestCase::class, | ||
| $class | ||
| ); |
There was a problem hiding this comment.
at first I built everything to throw an error, but now I think we should not throw, it's a little bit too much violent I think 😆 🥊
But since everything is ready to throw, I propose to keep it like this in the exception
nikophil
commented
Jan 9, 2025
| use Zenstruck\Foundry\Test\ResetDatabase; | ||
| use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory; | ||
|
|
||
| #[RequiresPhpunit('>=11.0')] |
There was a problem hiding this comment.
only PhpUnit 11 handles correctly deprecation, so all tests in this namespace will only be ran with phpunit 11
nikophil
force-pushed
the
feat/force-using-factories-trait-in-tests
branch
from
dcd6ef8 to
43b4e62
Compare
nikophil
force-pushed
the
feat/force-using-factories-trait-in-tests
branch
from
43b4e62 to
22ce3cf
Compare
nikophil
force-pushed
the
feat/force-using-factories-trait-in-tests
branch
from
22ce3cf to
2dc090a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750
This "feature" was actually very challenging! 🤯