Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using paratestphp/paratest #520

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

kbond
Copy link
Member

@kbond kbond commented Nov 14, 2023

Closes #103

@kbond
Copy link
Member Author

kbond commented Nov 14, 2023

@benr77, as you just implemented in your project, do you mind giving this a quick review to ensure I captured everything?

@benr77
Copy link

benr77 commented Nov 14, 2023

Looks good to me. The only thing I can think of to add, is that Global State should be minimised where possible, as this adds to the test startup time - not a worry when you are running your entire suite, but if you are just running a single test case or class then you have to wait for the global state to load first.

@kbond
Copy link
Member Author

kbond commented Nov 14, 2023

Thanks, I added a warning about this to the global state section.

@kbond kbond merged commit f33d52a into zenstruck:1.x Nov 14, 2023
22 checks passed
@kbond kbond deleted the doc/paratest branch November 14, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add performance section about brianium/paratest
2 participants