This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Add php 7.1 type hints #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snapshotpl this needs a rebase, sorry :-\ |
|
@Ocramius done! |
froschdesign
suggested changes
Mar 20, 2018
| @@ -24,7 +25,7 @@ | |||
| * | |||
| * {@inheritdoc} | |||
| */ | |||
| public function canCreate(\Psr\Container\ContainerInterface $container, $requestedName) | |||
| public function canCreate(ContainerInterface $container, string $requestedName): bool | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Any plans to release this feature of coding standard?
There was a problem hiding this comment.
Add your question to the related PR. Thanks!
| @@ -136,7 +136,7 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function canCreate(ContainerInterface $container, $requestedName) | |||
| public function canCreate(ContainerInterface $container, string $requestedName): bool | |||
| private function resolveParameterWithoutConfigService( | ||
| ContainerInterface $container, | ||
| string $requestedName | ||
| ): callable { |
|
This repository has been closed and moved to laminas/laminas-servicemanager; a new issue has been opened at laminas/laminas-servicemanager#14. |
|
This repository has been moved to laminas/laminas-servicemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.