[RED-2366] Add CBP support to requested_tickets api/v2/users/:id/tickets/requested #582
Conversation
fbvilela
force-pushed
the
fvilela/requested_tickets
branch
2 times, most recently
from
9051c87
to
cf35ad4
Compare
spec/macros/resource_macros.rb
Outdated
| @@ -41,6 +41,7 @@ def it_should_be_creatable(options = {}) | |||
|
|
|||
| VCR.use_cassette("#{described_class.to_s}_create_delete") do | |||
| @creatable_object.destroy | |||
| sleep(1) | |||
There was a problem hiding this comment.
A consideration, maybe not even for this PR:
if the object gets returned even after deletion, maybe it has an attribute deleted: true or something we can check and make the test pass?
spec/macros/resource_macros.rb
Outdated
| @@ -110,7 +114,7 @@ def it_should_be_deletable(options = {}) | |||
| if options[:find] | |||
| expect(obj.send(options[:find].first)).to eq(options[:find].last) | |||
| else | |||
| expect(obj).to be_nil | |||
| expect(obj.nil? || !obj.active?).to eq(true) | |||
There was a problem hiding this comment.
can you explain what's going on here?
There was a problem hiding this comment.
Can you (@fbvilela), test if the random_string fix works without this change?
There was a problem hiding this comment.
Casper, it didn't work.
This change is because OrganizationField is marked for deletion and returned with an active: false . It eventually gets deleted for real. I will reach out to the team but as for our code change here, I might try to make this specific for the organization field class.
There was a problem hiding this comment.
I will reach out to the team
Yeah this sounds like a bug to me, as discussed in slack.
make this specific for the organization field class
Yeah, if we keep this change, it should be specific to the case that is affected at least.
fbvilela
force-pushed
the
fvilela/requested_tickets
branch
from
cf35ad4
to
9fd13ee
Compare
Description
Adding CBP support to this api endpoint
References
#>#581