use ERB for templating

zendesk · Nov 6, 2012 · 47526d8 · 47526d8
1 parent a07b6de
commit 47526d8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/lib/kamcaptcha.rb b/lib/kamcaptcha.rb
@@ -30,8 +30,8 @@ def encrypt(string)
 
 Kamcaptcha.template = <<-END
   <div class="kamcaptcha">
-    <label for="kamcaptcha_input">%{label}</label><input type="text" id="kamcaptcha_input" name="kamcaptcha[input]" />
-    <input type="hidden" name="kamcaptcha[validation]" value="%{token}" />
-    <img src="%{image}" />
+    <label for="kamcaptcha_input"><%= label %></label><input type="text" id="kamcaptcha_input" name="kamcaptcha[input]" />
+    <input type="hidden" name="kamcaptcha[validation]" value="<%= token %>" />
+    <img src="<%= image %>" />
   </div>
 END
diff --git a/lib/kamcaptcha/helper.rb b/lib/kamcaptcha/helper.rb
@@ -1,3 +1,5 @@
+require 'erb'
+
 module Kamcaptcha
   module Helper
     DEFAULT_LABEL = "Please type the characters in the image below"
@@ -16,9 +18,12 @@ def kamcaptcha(options = {})
 
       instance_exec(token, &Kamcaptcha::Token.store) if Kamcaptcha::Token.store
 
-      form = template % { :label => label, :token => token, :image => image }
+      # Makes sure the ERB template only gets these variables: label, token, image
+      form = ERB.new(template).result(OpenStruct.new(:label => label, :token => token, :image => image).send(:binding))
+
       form = form.html_safe if form.respond_to?(:html_safe)
       form
     end
+
   end
 end
diff --git a/test/unit/test_helper.rb b/test/unit/test_helper.rb
@@ -57,7 +57,7 @@ class String
       before(:all) { @prefix, Kamcaptcha.prefix = Kamcaptcha.prefix, "omg/123" }
       after(:all) { Kamcaptcha.prefix = @prefix }
 
-      subject { Kamcaptcha.stub(:random, "hello.png") { kamcaptcha(:template => "%{image}") } }
+      subject { Kamcaptcha.stub(:random, "hello.png") { kamcaptcha(:template => "<%= image %>") } }
 
       it "should prefix image path" do
         assert_equal "/omg/123/hello.png", subject
@@ -68,7 +68,7 @@ class String
       before(:all) { @generator, Kamcaptcha::Token.generator = Kamcaptcha::Token.generator, lambda {|_| "token"}}
       after(:all) { Kamcaptcha::Token.generator = @generator }
 
-      subject { Kamcaptcha.stub(:random, "hello.png") { kamcaptcha(:template => "%{token}") } }
+      subject { Kamcaptcha.stub(:random, "hello.png") { kamcaptcha(:template => "<%= token %>") } }
 
       it "should use the custom generator" do
         assert_equal "token", subject