Fix installation of Python packages in generate docs CI job again #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pins the generate-docs GH workflow to run on a fixed version of ubuntu so we get defined semantics of pip install wrt system packages. We were previously using the ubuntu-latest image and GH has been switching this from ubuntu-22.04 to 24.04 and back again, also see actions/runner-images#10636.
ckreibich
approved these changes
Oct 18, 2024
awelzel
reviewed
Oct 21, 2024
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Fetch Dependencies | ||
| run: sudo pip3 install --break-system-packages -r requirements.txt | ||
| run: pip3 install -r requirements.txt |
There was a problem hiding this comment.
With actions/setup-python, shouldn't "break-system-packages" be mood? I wonder if the sudo part caused PATH to be reset, picking up the system's pip rather than the one from the corresponding actions/setup-python?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins the generate-docs GH workflow to run on a fixed version of ubuntu so we get defined semantics of pip install wrt system packages. We were previously using the ubuntu-latest image and GH has been switching this from ubuntu-22.04 to 24.04 and back again, also see actions/runner-images#10636.