return correct gRPC error codes #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryRuane
force-pushed
the
2024-10-error-codes-497
branch
from
4cacf9e
to
7236235
Compare
|
This PR includes some whitespace changes to common/common_test.go because my IDE (vscode) automatically formats files, and an earlier commit to this file used a different formatting convention. I recommend viewing the diff with whitespace ignored (click on the gear symbol near the top of the Files changed (diff) page). |
LarryRuane
force-pushed
the
2024-10-error-codes-497
branch
from
7236235
to
0c25590
Compare
upbqdn
reviewed
Nov 14, 2024
| // Fetch the block using the verbose option ("1") because it provides | ||
| // both the list of txids, which we're not yet able to compute for | ||
| // Orchard (V5) transactions, and the block hash (block ID), which | ||
| // we need to fetch the raw data format of the same block. Don't fetch | ||
| // by height in case a reorg occurs between the two getblock calls; | ||
| // using block hash ensures that we're fetching the same block. | ||
| params[1] = json.RawMessage("1") | ||
| params := []json.RawMessage{heightJSON, json.RawMessage("1")} | ||
| result, rpcErr := RawRequest("getblock", params) | ||
| if rpcErr != nil { | ||
| // Check to see if we are requesting a height the zcashd doesn't have yet |
There was a problem hiding this comment.
There was a problem hiding this comment.
It's -5 for hashes but -8 for heights. What is weird is the comment above mentioning that it should be a hash but it is not. That's not part of the PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #497