Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebrad instead of zcashd in error messages #489

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

LarryRuane
Copy link
Collaborator

Closes #488. Indicate the correct backend process name in error messages. Some error messages occur before we know if our backend is zcashd or zebrad (for example, when we're attempting the first RPC), so those will mention both as possibilities. A follow-on PR could mention the backend name in additional error messages (this PR corrects the only two, only one of which is a gRPC, GetTreeState(), the other in the block ingestor). I did test this PR with an instance of zebrad.

@LarryRuane LarryRuane requested a review from str4d July 8, 2024 04:29
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@daira daira merged commit c83db01 into zcash:master Aug 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors hard-code zcashd regardless of the actual full node backend
2 participants