Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_backend: Generalize & extend wallet metadata query API #1580

Merged
merged 2 commits into from
Nov 13, 2024

Apply suggestions from code review & Clippy fixes.

00cafa3
Select commit
Loading
Failed to load commit list.
Merged

zcash_client_backend: Generalize & extend wallet metadata query API #1580

Apply suggestions from code review & Clippy fixes.
00cafa3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

56.38% (+0.07%) compared to 8b49ca8

View this Pull Request on Codecov

56.38% (+0.07%) compared to 8b49ca8

Details

Codecov Report

Attention: Patch coverage is 69.68504% with 77 lines in your changes missing coverage. Please review.

Project coverage is 56.38%. Comparing base (8b49ca8) to head (00cafa3).

Files with missing lines Patch % Lines
zcash_client_backend/src/data_api/testing/pool.rs 62.50% 21 Missing ⚠️
zcash_client_backend/src/data_api.rs 60.00% 20 Missing ⚠️
zcash_client_sqlite/src/wallet/common.rs 77.92% 17 Missing ⚠️
zcash_client_backend/src/fees.rs 66.66% 9 Missing ⚠️
zcash_client_sqlite/src/lib.rs 33.33% 6 Missing ⚠️
zcash_client_backend/src/fees/common.rs 71.42% 2 Missing ⚠️
zcash_client_backend/src/data_api/testing.rs 94.44% 1 Missing ⚠️
zcash_client_sqlite/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   56.30%   56.38%   +0.07%     
==========================================
  Files         148      148              
  Lines       19062    19232     +170     
==========================================
+ Hits        10733    10844     +111     
- Misses       8329     8388      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov