Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust-toolchain to 1.61.0 #773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update rust-toolchain to 1.61.0 #773

wants to merge 1 commit into from

Conversation

therealyingtong
Copy link
Collaborator

This is needed for the package image v0.24.6.

@str4d
Copy link
Contributor

str4d commented May 1, 2023

The image dependency is only present because of the test-dev-graph feature flag, which is only present for halo2 devs to run tests. So we need to ensure that CI is still checking against MSRV after this change. I think it is, but only because we're using the deprecated actions-rs/toolchain. In other repos I've migrated away from that by using rust-toolchain.toml to encode the MSRV, and this PR would prevent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therealyingtong @str4d