Fix camera removal #200
Merged
Fix camera removal #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bug where remove_camera on a multi_camera_provider had no effect
… it is no longer required
pascalzauberzeug
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks good to me. Approved, if it's okay with you @denniswittich that the deprecation warning is probably never shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the removal of cameras in the
multi_camera_provider.The problem was that the camera removal works by modifying the dict returned by
self.cameras. However, themulti_camera_provideroverwrites this method to return a joined dict of all sub-providers. Consequently, the deletion had no effect.This PR also adds a deprecation warning for the
prune_imagesfunction which is outdated because images is a dequeue now.