Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning when force_reload is used on data sources #3895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show warning when force_reload is used on data sources #3895

wants to merge 1 commit into from
+4 −0

Conversation

rodja
Copy link
Member

@rodja rodja commented Oct 18, 2024 •
edited
Loading

This PR attempts to help the user understand that force_reload only makes sense on network urls. See #2566 (comment) more

@rodja rodja added the enhancement New feature or request label Oct 18, 2024
@rodja rodja added this to the 2.5 milestone Oct 18, 2024
@rodja rodja mentioned this pull request Oct 18, 2024
Closed
falkoschindler
falkoschindler requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rodja. But there are two problems with the current solution:

  • If source is a Path or PIL_Image, startswith is not defined.
  • We should update ui.image accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@rodja @falkoschindler