Skip to content

Commit

Permalink
cleanup and better naming
Browse files Browse the repository at this point in the history
  • Loading branch information
rodja committed Aug 21, 2023
1 parent 3e486bc commit a4de8a2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions learning_loop_node/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(self, name: str, uuid: str = None):
self.register_lifecycle_events()
self.sio_client = None

async def prepare(self):
async def startup(self):
await loop.backend_ready()
await loop.ensure_login()
await self.create_sio_client()
Expand Down Expand Up @@ -93,7 +93,7 @@ def register_lifecycle_events(self):
async def startup():
logging.debug('received "startup" event')
Node._activate_asyncio_warnings()
await self.prepare()
await self.startup()

@self.on_event("shutdown")
async def shutdown():
Expand Down
1 change: 0 additions & 1 deletion learning_loop_node/tests/test_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class LiveServerSession(Session):
def __init__(self, *args, **kwargs):
super(LiveServerSession, self).__init__(*args, **kwargs)
self.prefix_url = loop.web.base_url
ic(self.prefix_url)
self.cookies = self.get_cookies()

def request(self, method, url, *args, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion learning_loop_node/trainer/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async def test_trainer_node(request):
trainer = TestingTrainer()

node = TrainerNode(name='test', trainer=trainer, uuid='00000000-0000-0000-0000-000000000000')
await node.prepare()
await node.startup()

yield node

Expand Down
2 changes: 0 additions & 2 deletions mock_trainer/mock_trainer_tests/test_mock_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
async def create_mock_trainer() -> MockTrainer:
mock_trainer = MockTrainer(model_format='mocked')
mock_trainer.executor = Executor(GLOBALS.data_folder)
await mock_trainer.prepare()
await asyncio.sleep(14)
return mock_trainer


Expand Down

0 comments on commit a4de8a2

Please sign in to comment.