-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-pin numpy #2552
Un-pin numpy #2552
Conversation
numpy 2.2 changes the string repr for arrays (shape info is now displayed), maybe that's the culprit? |
From memory that's exactly it |
If you have the env, then running |
Ah amazing, thanks for sharing! https://github.com/scientific-python/pytest-doctestplus does a similar thing, but I'll checkout pytest-accept too |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## support/v2 #2552 +/- ##
===========================================
Coverage 99.95% 99.95%
===========================================
Files 38 38
Lines 14664 14666 +2
===========================================
+ Hits 14658 14660 +2
Misses 6 6
|
I pinned numpy in a previous PR because it was breaking tests 😭 . This un-pins it to see what's going wrong, and then hopefully fix it.