Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 🔧 fix Zappa.create_handler_venv win32 case wherestderror_result is None #1353

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

monkut
Copy link
Collaborator

@monkut monkut commented Sep 30, 2024

Description

Update Zappa.create_handler_venv, so that when the result from pip_process.communicate() returns None for stderr, an unrelated exception is NOT raised, and zappa.create_handler_venv proceeds as expected.

Currently, the code assumes a str value is returned, but on win32 systems, it appears that None may be returned.

GitHub Issues

#1342

@coveralls
Copy link

Coverage Status

coverage: 74.783% (+0.1%) from 74.648%
when pulling c9a7b79 on fix/win-slimhandler-error-handling-issue1342
into b00312d on master.

@monkut monkut requested a review from souravjamwal77 October 22, 2024 07:51
@monkut monkut enabled auto-merge (squash) October 22, 2024 08:01
Copy link

Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

@github-actions github-actions bot added the no-activity [Bot] Closing soon if no new activity label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-activity [Bot] Closing soon if no new activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants