Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributors list #225

Merged
merged 2 commits into from
May 29, 2024
Merged

update contributors list #225

merged 2 commits into from
May 29, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented May 29, 2024

No description provided.

@zapier-sre-bot
Copy link
Collaborator

Mergecat's Review

Click to read mergecats review!

😼 Mergecat review of README.md

@@ -36,13 +36,9 @@ The [contributing](https://kubechecks.readthedocs.io/en/stable/contributing/) ha
 To learn more about `kubechecks` [go to the complete documentation](https://kubechecks.readthedocs.io/).
 
 ## Contributors
-- [mplatcher](https://github.com/mplachter)
-- [sl1pm4t](https://github.com/sl1pm4t)
-- [polyrain](https://github.com/polyrain)
-- [jhouser](https://github.com/jhouser)
-- [davidwin93](https://github.com/davidwin93)
-- [sontek](https://github.com/sontek)
-- [MeNsaaH](https://github.com/MeNsaaH)
+
+![contributors](https://contrib.rocks/image?repo=zapier/kubechecks)
+
 ---
 
 Made by SRE Team @ ![zapier](https://zapier-media.s3.amazonaws.com/zapier/images/logo60orange.png)

Feedback & Suggestions:

  1. Loss of Individual Recognition: Replacing individual contributor links with a single image link removes personal recognition. Consider keeping individual links for better acknowledgment.
  2. Image Reliability: The contrib.rocks service might not be reliable or could change over time. Ensure that this service is stable and will not break the README in the future.
  3. Accessibility: The image does not provide alt text, which is important for accessibility. Add an alt attribute to the image tag.

Suggested Improvement:

@@ -36,13 +36,13 @@ The [contributing](https://kubechecks.readthedocs.io/en/stable/contributing/) ha
 To learn more about `kubechecks` [go to the complete documentation](https://kubechecks.readthedocs.io/).
 
 ## Contributors
-- [mplatcher](https://github.com/mplachter)
-- [sl1pm4t](https://github.com/sl1pm4t)
-- [polyrain](https://github.com/polyrain)
-- [jhouser](https://github.com/jhouser)
-- [davidwin93](https://github.com/davidwin93)
-- [sontek](https://github.com/sontek)
-- [MeNsaaH](https://github.com/MeNsaaH)
+
+![contributors](https://contrib.rocks/image?repo=zapier/kubechecks "Contributors")
+
+- [mplatcher](https://github.com/mplachter)
+- [sl1pm4t](https://github.com/sl1pm4t)
+- [polyrain](https://github.com/polyrain)
+- [jhouser](https://github.com/jhouser)
+- [davidwin93](https://github.com/davidwin93)
+- [sontek](https://github.com/sontek)
+- [MeNsaaH](https://github.com/MeNsaaH)
 ---
 
 Made by SRE Team @ ![zapier](https://zapier-media.s3.amazonaws.com/zapier/images/logo60orange.png)

This way, you maintain individual recognition while also including the contributors' image.



Dependency Review

Click to read mergecats review!

No suggestions found

@polyrain polyrain merged commit 3d48339 into main May 29, 2024
2 checks passed
@polyrain polyrain deleted the update-contributors branch May 29, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants