Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic related improvements #184

Merged
merged 3 commits into from
Apr 11, 2024
Merged

panic related improvements #184

merged 3 commits into from
Apr 11, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented Apr 4, 2024

report panics in app checks
protect against some concurrency issues that cause panics and errors
also bring back the footer

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Temporary image deleted.

polyrain
polyrain approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see the footer back. Hopefully this will make it a little less flakey on bigger runs, thanks for getting this done!

@djeebus djeebus merged commit f48a265 into main Apr 11, 2024
5 checks passed
@djeebus djeebus deleted the protect-processes branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polyrain polyrain polyrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djeebus @polyrain