Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase channels size and goroutine limits #175

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented Mar 27, 2024

When diffing large amounts of apps, kubechecks could get into a deadlock. This should increase the limits to some fairly reasonable numbers, but also makes the configurable in case they need to be increased further.

Copy link

github-actions bot commented Mar 27, 2024

Temporary image deleted.

Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djeebus djeebus merged commit 308cfb0 into main Mar 28, 2024
5 checks passed
@djeebus djeebus deleted the increase-channel-goroutine-limits branch March 28, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants