fix unused arg, log err

zapier · Feb 26, 2024 · bb38dfb · bb38dfb
1 parent a40c17e
commit bb38dfb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/cmd/container.go b/cmd/container.go
@@ -18,8 +18,9 @@ import (
 func newContainer(ctx context.Context, cfg config.ServerConfig) (container.Container, error) {
 	var err error
 
-	ctr := container.Container{}
-	ctr.Config = cfg
+	var ctr = container.Container{
+		Config: cfg,
+	}
 
 	switch cfg.VcsType {
 	case "gitlab":

diff --git a/pkg/app_watcher/app_watcher.go b/pkg/app_watcher/app_watcher.go
@@ -40,6 +40,7 @@ func NewApplicationWatcher(vcsToArgoMap appdir.VcsToArgoMap) (*ApplicationWatche
 
 	ctrl := ApplicationWatcher{
 		applicationClientset: appClient,
+		vcsToArgoMap:         vcsToArgoMap,
 	}
 
 	appInformer, appLister := ctrl.newApplicationInformerAndLister(time.Second * 30)
@@ -126,13 +127,15 @@ func (ctrl *ApplicationWatcher) newApplicationInformerAndLister(refreshTimeout t
 	)
 
 	lister := applisters.NewApplicationLister(informer.GetIndexer())
-	informer.AddEventHandler(
+	if _, err := informer.AddEventHandler(
 		cache.ResourceEventHandlerFuncs{
 			AddFunc:    ctrl.onApplicationAdded,
 			UpdateFunc: ctrl.onApplicationUpdated,
 			DeleteFunc: ctrl.onApplicationDeleted,
 		},
-	)
+	); err != nil {
+		log.Error().Err(err).Msg("failed to add event handlers")
+	}
 	return informer, lister
 }