Skip to content

Commit

Permalink
fix ci and remove unwanted comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Greyeye committed Jun 28, 2024
1 parent 137aa12 commit 6686a36
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build-image/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ runs:
- name: Build and push the Docker image
shell: bash
run: >-
./earthly
./earthly.sh
--push
+docker-multiarch
${{ inputs.tag_latest != 'false' && format('--LATEST_IMAGE_NAME=ghcr.io/{0}:latest', github.repository) || '' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on_pull-request_docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with: { version: "${{ env.EARTHLY_TOOL_VERSION }}" }

- name: rebuild the docs
run: ./earthly +rebuild-docs
run: ./earthly.sh +rebuild-docs

- name: verify that the checked in file has not changed
run: ./hacks/exit-on-changed-files.sh "Please run './earthly +rebuild-docs' and commit the results to this PR"
2 changes: 1 addition & 1 deletion .github/workflows/on_pull-request_helm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
- uses: earthly/actions-setup@v1
with: { version: "v${{ env.EARTHLY_TOOL_VERSION }}" }

- run: ./earthly +ci-helm
- run: ./earthly.sh +ci-helm
2 changes: 1 addition & 1 deletion .github/workflows/on_pull_request_go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:
- uses: earthly/actions-setup@v1
with: { version: "v${{ env.EARTHLY }}" }

- run: ./earthly +ci-golang
- run: ./earthly.sh +ci-golang
2 changes: 1 addition & 1 deletion .github/workflows/on_push_to_main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

- name: Build and push the helm charts
run: |
./earthly \
./earthly.sh \
--push \
+release-helm \
--repo_owner ${{ github.repository_owner }} \
Expand Down
10 changes: 0 additions & 10 deletions tools/dump_crds/cmd/dumpcrd/dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ Used to generate openAPIV3Schema for each CRD in the cluster. To be consumed by

func init() {
rootCmd.AddCommand(dumpCmd)

// Here you will define your flags and configuration settings.

// Cobra supports Persistent Flags which will work for this command
// and all subcommands, e.g.:
// dumpCmd.PersistentFlags().String("foo", "", "A help for foo")

// Cobra supports local flags which will only run when this command
// is called directly, e.g.:
// dumpCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
}

func dump() {
Expand Down

0 comments on commit 6686a36

Please sign in to comment.